From: Mike Yuan Date: Wed, 10 Apr 2024 11:18:19 +0000 (+0800) Subject: shared/open-file: make open_file_free_many static inline X-Git-Tag: v256-rc1~231^2~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4eb1feb110c008e9b08fa7e3d235ccef89643e75;p=thirdparty%2Fsystemd.git shared/open-file: make open_file_free_many static inline --- diff --git a/src/shared/open-file.c b/src/shared/open-file.c index beebb74cff4..09062d8e6e1 100644 --- a/src/shared/open-file.c +++ b/src/shared/open-file.c @@ -1,4 +1,3 @@ - /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include @@ -122,19 +121,14 @@ int open_file_to_string(const OpenFile *of, char **ret) { return 0; } -OpenFile *open_file_free(OpenFile *of) { +OpenFile* open_file_free(OpenFile *of) { if (!of) return NULL; free(of->path); free(of->fdname); - return mfree(of); -} -void open_file_free_many(OpenFile **head) { - assert(head); - - LIST_CLEAR(open_files, *head, open_file_free); + return mfree(of); } static const char * const open_file_flags_table[_OPENFILE_MAX] = { diff --git a/src/shared/open-file.h b/src/shared/open-file.h index bb63ec8f9c3..4999c96ae7f 100644 --- a/src/shared/open-file.h +++ b/src/shared/open-file.h @@ -1,8 +1,8 @@ - /* SPDX-License-Identifier: LGPL-2.1-or-later */ #pragma once #include "list.h" +#include "macro.h" typedef enum OpenFileFlag { OPENFILE_READ_ONLY = 1 << 0, @@ -27,10 +27,12 @@ int open_file_validate(const OpenFile *of); int open_file_to_string(const OpenFile *of, char **ret); -OpenFile *open_file_free(OpenFile *of); +OpenFile* open_file_free(OpenFile *of); DEFINE_TRIVIAL_CLEANUP_FUNC(OpenFile*, open_file_free); -void open_file_free_many(OpenFile **head); +static inline void open_file_free_many(OpenFile **head) { + LIST_CLEAR(open_files, *ASSERT_PTR(head), open_file_free); +} -const char *open_file_flags_to_string(OpenFileFlag t) _const_; +const char* open_file_flags_to_string(OpenFileFlag t) _const_; OpenFileFlag open_file_flags_from_string(const char *t) _pure_;