From: David Lawrence <dlawrence@mozilla.com>
Date: Fri, 21 Jan 2011 06:35:50 +0000 (-0500)
Subject: Bug 626292: "Make description private" checkbox should set bz_private class on the... 
X-Git-Tag: bugzilla-4.1.1~95
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4eb82e4c5479ff0ed99518f75a4aa2d24a4ec378;p=thirdparty%2Fbugzilla.git

Bug 626292: "Make description private" checkbox should set bz_private class on the comment box
r/a=mkanat
---

diff --git a/js/field.js b/js/field.js
index aa9cd6c7e0..621cdf3eba 100644
--- a/js/field.js
+++ b/js/field.js
@@ -443,11 +443,11 @@ function boldOnChange(e, field_id){
     }
 }
 
-function updateCommentTagControl(checkbox, form) {
+function updateCommentTagControl(checkbox, field) {
     if (checkbox.checked) {
-        form.comment.className='bz_private';
+        YAHOO.util.Dom.addClass(field, 'bz_private');
     } else {
-        form.comment.className='';
+        YAHOO.util.Dom.removeClass(field, 'bz_private');
     }
 }
 
diff --git a/template/en/default/bug/create/create.html.tmpl b/template/en/default/bug/create/create.html.tmpl
index 94aafe45d9..a2e7b7eaed 100644
--- a/template/en/default/bug/create/create.html.tmpl
+++ b/template/en/default/bug/create/create.html.tmpl
@@ -589,7 +589,8 @@ TUI_hide_default('attachment_text_field');
       <td colspan="3">
         &nbsp;&nbsp;
         <input type="checkbox" id="comment_is_private" name="comment_is_private"
-          [% ' checked="checked"' IF comment_is_private %]>
+          [% ' checked="checked"' IF comment_is_private %]
+               onClick="updateCommentTagControl(this, 'comment')">
         <label for="comment_is_private">
           Make description private (visible only to members of the 
           <strong>[% Param('insidergroup') FILTER html %]</strong> group)
diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl
index e8eaaad1f0..1ae71b2990 100644
--- a/template/en/default/bug/edit.html.tmpl
+++ b/template/en/default/bug/edit.html.tmpl
@@ -60,6 +60,7 @@
     [% IF user.is_insider %]
       if (document.getElementById('isprivate_' + real_id).checked) {
           document.getElementById('newcommentprivacy').checked = 'checked';
+          updateCommentTagControl(document.getElementById('newcommentprivacy'), 'comment'); 
       }
     [% END %]
 
@@ -130,7 +131,7 @@
   //-->
   </script>
 
-<form name="changeform" method="post" action="process_bug.cgi">
+<form name="changeform" id="changeform" method="post" action="process_bug.cgi">
 
   <input type="hidden" name="delta_ts" value="[% bug.delta_ts %]">
   <input type="hidden" name="longdesclength" value="[% bug.comments.size %]">
@@ -1066,7 +1067,7 @@
       [% IF user.is_insider %]
         <input type="checkbox" name="comment_is_private" value="1"
                id="newcommentprivacy"
-               onClick="updateCommentTagControl(this, form)">
+               onClick="updateCommentTagControl(this, 'comment')">
         <label for="newcommentprivacy">
           Make comment private (visible only to members of the
           <strong>[% Param('insidergroup') FILTER html %]</strong> group)