From: Brad Allen Date: Tue, 16 Mar 2010 02:34:34 +0000 (-0600) Subject: Removed custom do_execute which called cursor.executedirect, after discussion with... X-Git-Tag: rel_0_6beta2~53 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4ed1f0e57faa3ebd0f7cd9e46e1ab5671f4f54d4;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git Removed custom do_execute which called cursor.executedirect, after discussion with eGenix and zzzeek. Even though more tests pass with executedirect, it is not appropriate for default usage because it does not issue prepare statements to the db, and it forces Python type binding. The executedirect method should only be called when the API user specifically requests it for special case performance reasons. --- diff --git a/lib/sqlalchemy/connectors/mxodbc.py b/lib/sqlalchemy/connectors/mxodbc.py index 2374b4c95c..5e1d443afa 100644 --- a/lib/sqlalchemy/connectors/mxodbc.py +++ b/lib/sqlalchemy/connectors/mxodbc.py @@ -79,9 +79,7 @@ class MxODBCConnector(Connector): except ValueError: version.append(n) return tuple(version) - - def do_execute(self, cursor, statement, parameters, context=None): - cursor.executedirect(statement, tuple(parameters)) +