From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 26 Oct 2021 13:29:31 +0000 (+0200)
Subject: dnsdist: Make ConnectionToBackend::release() purely virtual
X-Git-Tag: rec-4.6.0-beta1~28^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4ed2c08ccbcc4b6c6b4a72379ae5e9aaa64ff69f;p=thirdparty%2Fpdns.git

dnsdist: Make ConnectionToBackend::release() purely virtual
---

diff --git a/pdns/dnsdistdist/dnsdist-nghttp2.cc b/pdns/dnsdistdist/dnsdist-nghttp2.cc
index 1536c09ec8..44bd7058d0 100644
--- a/pdns/dnsdistdist/dnsdist-nghttp2.cc
+++ b/pdns/dnsdistdist/dnsdist-nghttp2.cc
@@ -67,6 +67,9 @@ public:
   bool reachedMaxConcurrentQueries() const override;
   bool reachedMaxStreamID() const override;
   bool isIdle() const override;
+  void release() override
+  {
+  }
 
 private:
   static ssize_t send_callback(nghttp2_session* session, const uint8_t* data, size_t length, int flags, void* user_data);
diff --git a/pdns/dnsdistdist/dnsdist-tcp-downstream.hh b/pdns/dnsdistdist/dnsdist-tcp-downstream.hh
index ac9d7e29cf..7832786139 100644
--- a/pdns/dnsdistdist/dnsdist-tcp-downstream.hh
+++ b/pdns/dnsdistdist/dnsdist-tcp-downstream.hh
@@ -115,9 +115,7 @@ public:
   virtual bool reachedMaxStreamID() const = 0;
   virtual bool reachedMaxConcurrentQueries() const = 0;
   virtual bool isIdle() const = 0;
-  virtual void release()
-  {
-  }
+  virtual void release() = 0;
 
   bool matches(const std::shared_ptr<DownstreamState>& ds) const
   {