From: mkanat%bugzilla.org <>
Date: Sun, 23 Dec 2007 06:25:01 +0000 (+0000)
Subject: Bug 409463: The flagtypes.description DB format is not the same in an upgraded instal... 
X-Git-Tag: bugzilla-3.1.3~422
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4ee554d7d2a5a6a6f1e89f253afd9112f360d11e;p=thirdparty%2Fbugzilla.git

Bug 409463: The flagtypes.description DB format is not the same in an upgraded installation and in a fresh one
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat
---

diff --git a/Bugzilla/DB/Schema.pm b/Bugzilla/DB/Schema.pm
index 2be64cab3a..3d7f56674a 100644
--- a/Bugzilla/DB/Schema.pm
+++ b/Bugzilla/DB/Schema.pm
@@ -470,7 +470,7 @@ use constant ABSTRACT_SCHEMA => {
             id               => {TYPE => 'SMALLSERIAL', NOTNULL => 1,
                                  PRIMARYKEY => 1},
             name             => {TYPE => 'varchar(50)', NOTNULL => 1},
-            description      => {TYPE => 'MEDIUMTEXT'},
+            description      => {TYPE => 'MEDIUMTEXT', NOTNULL => 1},
             cc_list          => {TYPE => 'varchar(200)'},
             target_type      => {TYPE => 'char(1)', NOTNULL => 1,
                                  DEFAULT => "'b'"},
diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm
index 3b44f30167..43c81d1dd9 100644
--- a/Bugzilla/Install/DB.pm
+++ b/Bugzilla/Install/DB.pm
@@ -2948,8 +2948,9 @@ sub change_text_types {
         { TYPE => 'TINYTEXT', NOTNULL => 1 });
     $dbh->bz_alter_column('attachments', 'mimetype',
         { TYPE => 'TINYTEXT', NOTNULL => 1 });
+    # This also changes NULL to NOT NULL.
     $dbh->bz_alter_column('flagtypes', 'description',
-        { TYPE => 'MEDIUMTEXT', NOTNULL => 1 });
+        { TYPE => 'MEDIUMTEXT', NOTNULL => 1 }, '');
     $dbh->bz_alter_column('fielddefs', 'description',
         { TYPE => 'TINYTEXT', NOTNULL => 1 });
     $dbh->bz_alter_column('namedqueries', 'query',