From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 4 Jun 2015 14:46:20 +0000 (-0400)
Subject: Make debug messages consistent for bad packets
X-Git-Tag: release_3_0_9~279
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4eeddb96796394c6ca65bd8b4654cc6e5998824f;p=thirdparty%2Ffreeradius-server.git

Make debug messages consistent for bad packets
---

diff --git a/src/main/listen.c b/src/main/listen.c
index c12bde28f4d..5759639365d 100644
--- a/src/main/listen.c
+++ b/src/main/listen.c
@@ -272,6 +272,7 @@ RADCLIENT *client_listener_find(rad_listen_t *listener,
 	request->packet = rad_recv(NULL, listener->fd, 0x02); /* MSG_PEEK */
 	if (!request->packet) {				/* badly formed, etc */
 		talloc_free(request);
+		ERROR("Receive - %s", fr_strerror());
 		goto unknown;
 	}
 	(void) talloc_steal(request, request->packet);
@@ -1472,7 +1473,7 @@ static int stats_socket_recv(rad_listen_t *listener)
 	packet = rad_recv(NULL, listener->fd, 1); /* require message authenticator */
 	if (!packet) {
 		FR_STATS_INC(auth, total_malformed_requests);
-		DEBUG("%s", fr_strerror());
+		ERROR("Receive - %s", fr_strerror());
 		return 0;
 	}
 
@@ -1566,7 +1567,7 @@ static int auth_socket_recv(rad_listen_t *listener)
 	if (!packet) {
 		talloc_free(ctx);
 		FR_STATS_INC(auth, total_malformed_requests);
-		DEBUG("%s", fr_strerror());
+		ERROR("Receive - %s", fr_strerror());
 		return 0;
 	}
 
@@ -1680,7 +1681,7 @@ static int acct_socket_recv(rad_listen_t *listener)
 	packet = rad_recv(ctx, listener->fd, 0);
 	if (!packet) {
 		FR_STATS_INC(acct, total_malformed_requests);
-		ERROR("%s", fr_strerror());
+		ERROR("Receive - %s", fr_strerror());
 		return 0;
 	}
 
@@ -1946,7 +1947,7 @@ static int coa_socket_recv(rad_listen_t *listener)
 	packet = rad_recv(ctx, listener->fd, client->message_authenticator);
 	if (!packet) {
 		FR_STATS_INC(coa, total_malformed_requests);
-		DEBUG("%s", fr_strerror());
+		ERROR("Receive - %s", fr_strerror());
 		return 0;
 	}
 
@@ -1971,7 +1972,7 @@ static int proxy_socket_recv(rad_listen_t *listener)
 
 	packet = rad_recv(NULL, listener->fd, 0);
 	if (!packet) {
-		ERROR("%s", fr_strerror());
+		ERROR("Receive - %s", fr_strerror());
 		return 0;
 	}
 
diff --git a/src/main/tls_listen.c b/src/main/tls_listen.c
index 4cb2a7581d3..d0c6c999d77 100644
--- a/src/main/tls_listen.c
+++ b/src/main/tls_listen.c
@@ -289,7 +289,7 @@ static int tls_socket_recv(rad_listen_t *listener)
 	PTHREAD_MUTEX_UNLOCK(&sock->mutex);
 
 	if (!rad_packet_ok(packet, 0, NULL)) {
-		RDEBUG("Received bad packet: %s", fr_strerror());
+		ERROR("Receive - %s", fr_strerror());
 		DEBUG("Closing TLS socket from client");
 		PTHREAD_MUTEX_LOCK(&sock->mutex);
 		tls_socket_close(listener);