From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 14 Mar 2016 09:50:53 +0000 (+0100)
Subject: curl: glob_range: no need to check unsigned variable for negative
X-Git-Tag: curl-7_48_0~40
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4ef6d6b1bc8c4345f81531274492f188c8e99976;p=thirdparty%2Fcurl.git

curl: glob_range: no need to check unsigned variable for negative

cppcheck warned:

[src/tool_urlglob.c:283]: (style) Checking if unsigned variable 'step_n'
is less than zero.
---

diff --git a/src/tool_urlglob.c b/src/tool_urlglob.c
index f1dd27fad0..70d17fed11 100644
--- a/src/tool_urlglob.c
+++ b/src/tool_urlglob.c
@@ -5,7 +5,7 @@
  *                            | (__| |_| |  _ <| |___
  *                             \___|\___/|_| \_\_____|
  *
- * Copyright (C) 1998 - 2015, Daniel Stenberg, <daniel@haxx.se>, et al.
+ * Copyright (C) 1998 - 2016, Daniel Stenberg, <daniel@haxx.se>, et al.
  *
  * This software is licensed as described in the file COPYING, which
  * you should have received as part of this distribution. The terms
@@ -279,8 +279,7 @@ static CURLcode glob_range(URLGlob *glob, char **patternp,
 
     *posp += (pattern - *patternp);
 
-    if(!endp || (min_n > max_n) || (step_n > (max_n - min_n)) ||
-       (step_n <= 0) )
+    if(!endp || (min_n > max_n) || (step_n > (max_n - min_n)) || !step_n)
       /* the pattern is not well-formed */
       return GLOBERROR("bad range", *posp, CURLE_URL_MALFORMAT);