From: Christian Hofstaedtler <christian.hofstaedtler@deduktiva.com>
Date: Fri, 7 Oct 2016 00:41:13 +0000 (+0200)
Subject: pipebackend: fix var shadowing
X-Git-Tag: dnsdist-1.1.0-beta2~88^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f109c0220a6a2b488e786a44847a955c42d98d7;p=thirdparty%2Fpdns.git

pipebackend: fix var shadowing
---

diff --git a/modules/pipebackend/pipebackend.cc b/modules/pipebackend/pipebackend.cc
index 98ec55297e..03e2a6c918 100644
--- a/modules/pipebackend/pipebackend.cc
+++ b/modules/pipebackend/pipebackend.cc
@@ -223,9 +223,7 @@ bool PipeBackend::list(const DNSName& target, int inZoneId, bool include_disable
 
 string PipeBackend::directBackendCmd(const string &query) {
   if (d_abiVersion < 5)
-    return "not supported on ABI version " + std::to_string(d_abiVersion) + "(use ABI version 5 or later)\n";
-
-  ostringstream oss;
+    return "not supported on ABI version " + std::to_string(d_abiVersion) + " (use ABI version 5 or later)\n";
 
   try {
     launch();
@@ -237,8 +235,8 @@ string PipeBackend::directBackendCmd(const string &query) {
     L<<Logger::Error<<kBackendId<<" Error from coprocess: "<<ae.reason<<endl;
     cleanup();
   }
-  oss.str("");
 
+  ostringstream oss;
   while(true) {
     string line;
     d_coproc->receive(line);