From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Fri, 23 Dec 2016 17:26:17 +0000 (-0500)
Subject: lib: istream-sized - remove explicit i_error() logging
X-Git-Tag: 2.3.0.rc1~2360
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f22781ec4cd5bc1bfdfe856cbaed40b2ab137f6;p=thirdparty%2Fdovecot%2Fcore.git

lib: istream-sized - remove explicit i_error() logging

The stream_errno is set, so it's the caller's responsibility to log the
error. There's no need to log it twice.
---

diff --git a/src/lib/istream-sized.c b/src/lib/istream-sized.c
index 0853cc429a..6f54c5317b 100644
--- a/src/lib/istream-sized.c
+++ b/src/lib/istream-sized.c
@@ -89,9 +89,6 @@ static ssize_t i_stream_sized_read(struct istream_private *stream)
 	else if (pos > left) {
 		error = sstream->error_callback(&data, sstream->error_context);
 		io_stream_set_error(&stream->iostream, "%s", error);
-		i_error("read(%s) failed: %s",
-			i_stream_get_name(&stream->istream),
-			stream->iostream.error);
 		pos = left;
 		stream->istream.eof = TRUE;
 		stream->istream.stream_errno = EINVAL;
@@ -103,9 +100,6 @@ static ssize_t i_stream_sized_read(struct istream_private *stream)
 	} else {
 		error = sstream->error_callback(&data, sstream->error_context);
 		io_stream_set_error(&stream->iostream, "%s", error);
-		i_error("read(%s) failed: %s",
-			i_stream_get_name(&stream->istream),
-			stream->iostream.error);
 		stream->istream.stream_errno = EINVAL;
 	}