From: Wang Rui <moon.wangrui@huawei.com>
Date: Mon, 1 Sep 2014 12:08:06 +0000 (+0800)
Subject: qemu_process: Resolve Coverity RESOURCE_LEAK
X-Git-Tag: CVE-2014-3633~173
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f2ad084bc6d82b5d76b2e4937b3dc1a5d7a137d;p=thirdparty%2Flibvirt.git

qemu_process: Resolve Coverity RESOURCE_LEAK

If virSecurityManagerClearSocketLabel() fails, 'agent' won't
be freed before jumping to cleanup.

Signed-off-by: Wang Rui <moon.wangrui@huawei.com>
---

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index f76aa5a3b6..d9547b2064 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -264,6 +264,7 @@ qemuConnectAgent(virQEMUDriverPtr driver, virDomainObjPtr vm)
                                            vm->def) < 0) {
         VIR_ERROR(_("Failed to clear security context for agent for %s"),
                   vm->def->name);
+        qemuAgentClose(agent);
         goto cleanup;
     }