From: Neil Horman Date: Fri, 28 Feb 2025 18:58:48 +0000 (-0500) Subject: Remove empty buffer check in script_84 of quic_multistream_test X-Git-Tag: openssl-3.5.0-alpha1~38 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f2f5179a11920d36381fef299259e51953d72e9;p=thirdparty%2Fopenssl.git Remove empty buffer check in script_84 of quic_multistream_test The quic_multistream_test occasionally fails script_84, specifically failing on: OP_CHECK2(check_write_buf_stat, 0, 0) which fails due to the send stream buffer not reading zero after data is sent on the stream However, the send stream is culled of pending data, not after the stream is sent, but rather only after the peer sends an ack confirming that the data has been received. There is no guarantee that ACK will be sent immediately, so occasionally timing discrepancies result in the test not getting that ack by the time we check the send stream buffer. We couldmodify the script to wait longer, or repeatedly tick the quic stack to wait for that ack to be collected, but since its perfectly valid for that data to live in the ring buffer for a period, and that any true erroneous keeping of that data beyond its ack point would manifest as any number of other duplicate transmissions, it seems more sane to just remove the check. Fixes openssl/project#1117 Reviewed-by: Saša Nedvědický Reviewed-by: Tim Hudson (Merged from https://github.com/openssl/openssl/pull/26939) --- diff --git a/test/quic_multistream_test.c b/test/quic_multistream_test.c index e241b5cca86..dddba28f0d3 100644 --- a/test/quic_multistream_test.c +++ b/test/quic_multistream_test.c @@ -5542,7 +5542,6 @@ static const struct script_op script_84[] = { OP_S_READ_EXPECT (a, "apple", 5) OP_S_WRITE (a, "orange", 6) OP_C_READ_EXPECT (a, "orange", 6) - OP_CHECK2 (check_write_buf_stat, 0, 0) OP_END };