From: Stefan Eissing <stefan@eissing.org>
Date: Fri, 4 Apr 2025 16:10:28 +0000 (+0200)
Subject: https-connect, fix httpsrr target check
X-Git-Tag: curl-8_14_0~363
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f3c22d77d752fea6ff9ab2706f70d58882ea466;p=thirdparty%2Fcurl.git

https-connect, fix httpsrr target check

The HTTPSRR check on the record's target was not working as it used the
wrong index on the NUL byte if the target was not NULL.

Fixes #16966
Reported-by: Pavel Kropachev
Closes #16968
---

diff --git a/lib/cf-https-connect.c b/lib/cf-https-connect.c
index 7b14a01abe..9b80d9003c 100644
--- a/lib/cf-https-connect.c
+++ b/lib/cf-https-connect.c
@@ -673,7 +673,7 @@ CURLcode Curl_cf_https_setup(struct Curl_easy *data,
        (!conn->dns_entry->hinfo->target ||      /* for same host */
         !conn->dns_entry->hinfo->target[0] ||
         (conn->dns_entry->hinfo->target[0] == '.' &&
-         !conn->dns_entry->hinfo->target[0])) &&
+         !conn->dns_entry->hinfo->target[1])) &&
        (conn->dns_entry->hinfo->port < 0 ||    /* for same port */
         conn->dns_entry->hinfo->port == conn->remote_port)) {
       size_t i;