From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 7 Feb 2023 20:53:54 +0000 (-0600)
Subject: tacacs: We already have a hex printing function, and it doesn't use depricated sprint... 
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f3e39b9258c6c17dc2e1991d81c45ff9f17ba99;p=thirdparty%2Ffreeradius-server.git

tacacs: We already have a hex printing function, and it doesn't use depricated sprintf functions
---

diff --git a/src/protocols/tacacs/base.c b/src/protocols/tacacs/base.c
index 0ed4fd07082..7862b8858a2 100644
--- a/src/protocols/tacacs/base.c
+++ b/src/protocols/tacacs/base.c
@@ -299,9 +299,6 @@ ssize_t fr_tacacs_length(uint8_t const *buffer, size_t buffer_len)
 
 static void print_hex(fr_log_t const *log, char const *file, int line, char const *prefix, uint8_t const *data, size_t datalen, uint8_t const *end)
 {
-	size_t i, j, left;
-	char buffer[16*3+1];
-
 	if ((data + datalen) > end) {
 		fr_assert(data <= end);
 
@@ -315,22 +312,7 @@ static void print_hex(fr_log_t const *log, char const *file, int line, char cons
 
 	if (!datalen) return;
 
-	for (i = 0; i < datalen; i += 16) {
-		char *q = buffer;
-
-		left = 16;
-		if ((i + left) > datalen) left = datalen - i;
-
-		for (j = 0; j < left; j++) {
-			sprintf(q, "%02x ", data[i + j]);
-			q += 3;
-		}
-
-		q--;
-		*q = '\0';
-
-		fr_log(log, L_DBG, file, line, "%s %s", prefix, buffer);
-	}
+	fr_log_hex(log, L_DBG, file, line, data, datalen, "%s", prefix);
 }
 
 static void print_ascii(fr_log_t const *log, char const *file, int line, char const *prefix, uint8_t const *data, size_t datalen, uint8_t const *end)