From: Björn Jacke <bj@sernet.de>
Date: Fri, 23 Aug 2019 00:19:20 +0000 (+0200)
Subject: wscript_build: string concatenation efficiency cleanup
X-Git-Tag: talloc-2.3.1~712
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f5c4df316dc029f7b5ed6e8e48636dc61ecfe22;p=thirdparty%2Fsamba.git

wscript_build: string concatenation efficiency cleanup

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>

Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Tue Sep 24 13:40:21 UTC 2019 on sn-devel-184
---

diff --git a/docs-xml/wscript_build b/docs-xml/wscript_build
index f207e51ff21..b85309d4ead 100644
--- a/docs-xml/wscript_build
+++ b/docs-xml/wscript_build
@@ -115,26 +115,22 @@ def smbdotconf_generate_parameter_list(task):
     articles = task.inputs
 
     entities = bld.pathconfig_entities()
-    t = "<!DOCTYPE section [\n"
-
-    for entity in entities:
-        t += "%s\n" % entity
 
     # We need this if we build with Heimdal
     mit_kdc_path = '"/usr/sbin/krb5kdc"'
-
     # The MIT krb5kdc path is set if we build with MIT Kerberos
     if bld.CONFIG_SET('MIT_KDC_PATH'):
         mit_kdc_path = bld.CONFIG_GET('MIT_KDC_PATH')
 
-    t += "<!ENTITY pathconfig.MITKDCPATH   %s>\n" % mit_kdc_path
-
-    t += "]>\n"
-    t += "<section>\n"
-    for article in articles:
-        t += article.read()
+    t = "<!DOCTYPE section [\n" +\
+        "\n".join(entities) +\
+        "\n" +\
+        "<!ENTITY pathconfig.MITKDCPATH   " + mit_kdc_path + ">\n" +\
+        "]>\n" +\
+        "<section>\n" +\
+        "".join(art.read() for art in articles) +\
+	"</section>\n"
 
-    t += "</section>\n"
     save_file(parameter_all, t , create_dir=True)
     return 0