From: Byron Jones <bjones@mozilla.com>
Date: Tue, 8 May 2012 06:10:16 +0000 (+0800)
Subject: Bug 744015: Fix 'use of uninitialized value in string' in PatchReader
X-Git-Tag: bugzilla-4.3.2~86
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f608d4d3489935d55c20e15cc2ec7d700887ed4;p=thirdparty%2Fbugzilla.git

Bug 744015: Fix 'use of uninitialized value in string' in PatchReader
r=gerv, a=LpSolit
---

diff --git a/Bugzilla/Attachment/PatchReader.pm b/Bugzilla/Attachment/PatchReader.pm
index 3be0555c10..c79b96ed2f 100644
--- a/Bugzilla/Attachment/PatchReader.pm
+++ b/Bugzilla/Attachment/PatchReader.pm
@@ -200,7 +200,9 @@ sub warn_if_interdiff_might_fail {
 
     # Verify that the revisions in the files are the same.
     foreach my $file (keys %{$old_file_list}) {
-        if ($old_file_list->{$file}{old_revision} ne
+        if (exists $old_file_list->{$file}{old_revision}
+            && exists $new_file_list->{$file}{old_revision}
+            && $old_file_list->{$file}{old_revision} ne
             $new_file_list->{$file}{old_revision})
         {
             return 'interdiff2';