From: Mark Spencer <markster@digium.com>
Date: Thu, 17 Jun 2004 04:42:03 +0000 (+0000)
Subject: Fix doubly-linked list delete
X-Git-Tag: 1.0.0-rc1~224
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f72a1da7727cb5ea0a4ddef8853f913304ad169;p=thirdparty%2Fasterisk.git

Fix doubly-linked list delete


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_meetme.c b/apps/app_meetme.c
index 57cb46f019..9b513661ad 100755
--- a/apps/app_meetme.c
+++ b/apps/app_meetme.c
@@ -938,14 +938,30 @@ outrun:
 		} else {
 			/* Remove the user struct */ 
 			if (user == conf->firstuser) {
-				user->nextuser->prevuser = NULL;
+				if (user->nextuser) {
+					/* There is another entry */
+					user->nextuser->prevuser = NULL;
+				} else {
+					/* We are the only entry */
+					conf->lastuser = NULL;
+				}
+				/* In either case */
 				conf->firstuser = user->nextuser;
 			} else if (user == conf->lastuser){
-				user->prevuser->nextuser = NULL;
+				if (user->prevuser)
+					user->prevuser->nextuser = NULL;
+				else
+					ast_log(LOG_ERROR, "Bad bad bad!  We're the last, not the first, but nobody before us??\n");
 				conf->lastuser = user->prevuser;
 			} else {
-				user->nextuser->prevuser = user->prevuser;
-				user->prevuser->nextuser = user->nextuser;
+				if (user->nextuser)
+					user->nextuser->prevuser = user->prevuser;
+				else
+					ast_log(LOG_ERROR, "Bad! Bad! Bad! user->nextuser is NULL but we're not the end!\n");
+				if (user->prevuser)
+					user->prevuser->nextuser = user->nextuser;
+				else
+					ast_log(LOG_ERROR, "Bad! Bad! Bad! user->prevuser is NULL but we're not the beginning!\n");
 			}
 			/* Return the number of seconds the user was in the conf */
 			sprintf(meetmesecs, "%i", (int) (user->jointime - time(NULL)));