From: Christopher Faulet Date: Wed, 16 Jul 2025 09:29:49 +0000 (+0200) Subject: BUG/MINOR: applet: Don't trigger BUG_ON if the tid is not on appctx init X-Git-Tag: v3.3-dev4~73 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f7c26cbb33fac44b255c714610191ffad2ec653;p=thirdparty%2Fhaproxy.git BUG/MINOR: applet: Don't trigger BUG_ON if the tid is not on appctx init When an appctx is initialized, there is a BUG_ON() to be sure the appctx is really initialized on the right thread to avoid bugs on the thread affinity. However, it is possible to not choose the thread when the appctx is created and let it starts on any thread. In that case, the thread affinity is set when the appctx is initialized. So, we must take cate to not trigger the BUG_ON() in that case. For now, we never hit the bug because the thread affinity is always set during the appctx creation. This patch must be backport as far as 2.8. --- diff --git a/include/haproxy/applet.h b/include/haproxy/applet.h index e9357e773..65e1af67e 100644 --- a/include/haproxy/applet.h +++ b/include/haproxy/applet.h @@ -116,7 +116,7 @@ static inline int appctx_init(struct appctx *appctx) * the appctx will be fully initialized. The session and the stream will * eventually be created. The affinity must be set now ! */ - BUG_ON(appctx->t->tid != tid); + BUG_ON(appctx->t->tid != -1 && appctx->t->tid != tid); task_set_thread(appctx->t, tid); if (appctx->applet->init)