From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 8 Apr 2025 18:03:16 +0000 (-0400)
Subject: hoist NULL check to before dereference
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f897e3933ff45065a0b4fabd4dc6adc3871988c;p=thirdparty%2Ffreeradius-server.git

hoist NULL check to before dereference
---

diff --git a/src/main/realms.c b/src/main/realms.c
index 9d9d990bee..75a38b7407 100644
--- a/src/main/realms.c
+++ b/src/main/realms.c
@@ -1640,6 +1640,11 @@ static int server_pool_add(realm_config_t *rc,
 			}
 		}
 
+		if (!home) {
+			ERROR("Failed to find home server %s", value);
+			goto error;
+		}
+
 		if (home->affinity) {
 			if (home->virtual_server) {
 				ERROR("Home server %s is a virtual server, and cannot be used with 'affinity'", home->name);				
@@ -1669,11 +1674,6 @@ static int server_pool_add(realm_config_t *rc,
 			pool->affinity_group[home->affinity] = home;			
 		}
 
-		if (!home) {
-			ERROR("Failed to find home server %s", value);
-			goto error;
-		}
-
 		if (do_print) cf_log_info(cs, "\thome_server = %s", home->name);
 		pool->servers[num_home_servers++] = home;
 	} /* loop over home_server's */