From: Tomas Mraz <tomas@openssl.org>
Date: Thu, 18 Jul 2024 09:01:00 +0000 (+0200)
Subject: Avoid leaking *ba_ret on reconnections
X-Git-Tag: openssl-3.4.0-alpha1~261
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4fa9d1f40fc85d8c70c93168dc812217db349359;p=thirdparty%2Fopenssl.git

Avoid leaking *ba_ret on reconnections

Also fixes Coverity 1604639
There is no point in checking ba_ret as it can never be NULL.

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/24931)
---

diff --git a/apps/lib/s_socket.c b/apps/lib/s_socket.c
index 46c00282232..88107ffe4d6 100644
--- a/apps/lib/s_socket.c
+++ b/apps/lib/s_socket.c
@@ -84,9 +84,6 @@ int init_client(int *sock, const char *host, const char *port,
     int ret;
     int options = 0;
 
-    if (tfo && ba_ret != NULL)
-        *ba_ret = NULL;
-
     if (BIO_sock_init() != 1)
         return 0;
 
diff --git a/apps/s_client.c b/apps/s_client.c
index b52c69d0b20..506048818b6 100644
--- a/apps/s_client.c
+++ b/apps/s_client.c
@@ -2167,6 +2167,9 @@ int s_client_main(int argc, char **argv)
     if (tfo)
         BIO_printf(bio_c_out, "Connecting via TFO\n");
  re_start:
+    /* peer_addr might be set from previous connections */
+    BIO_ADDR_free(peer_addr);
+    peer_addr = NULL;
     if (init_client(&sock, host, port, bindhost, bindport, socket_family,
                     socket_type, protocol, tfo, !isquic, &peer_addr) == 0) {
         BIO_printf(bio_err, "connect:errno=%d\n", get_last_socket_error());