From: Michael Kuron <m.kuron@gmx.de>
Date: Sun, 20 Aug 2017 13:15:37 +0000 (+0200)
Subject: res_xmpp: fix inverted return code check in OAuth
X-Git-Tag: 13.18.0-rc1~87^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4faf77feecefd1775449a94867e4b7e290828ff6;p=thirdparty%2Fasterisk.git

res_xmpp: fix inverted return code check in OAuth

fetch_access_token calls func_curl via ast_func_read. The latter returns 0 upon
success and -1 if the function is not available.
This commit inverts the return code check so that an error is printed if the
module is not loaded and not if it is loaded.

ASTERISK-27207 #close

Change-Id: I9ef903f80702d1218e8701f65a4e5e918e6548fb
---

diff --git a/res/res_xmpp.c b/res/res_xmpp.c
index bff59b842f..d8487f5ba8 100644
--- a/res/res_xmpp.c
+++ b/res/res_xmpp.c
@@ -3917,7 +3917,7 @@ static int fetch_access_token(struct ast_xmpp_client_config *cfg)
 	ast_debug(2, "Performing OAuth 2.0 authentication for client '%s' using command: %s\n",
 		cfg->name, cmd);
 
-	if (!ast_func_read(NULL, cmd, cBuf, sizeof(cBuf) - 1)) {
+	if (ast_func_read(NULL, cmd, cBuf, sizeof(cBuf) - 1)) {
 		ast_log(LOG_ERROR, "CURL is unavailable. This is required for OAuth 2.0 authentication of XMPP client '%s'. Please ensure it is loaded.\n",
 			cfg->name);
 		return -1;