From: Jouni Malinen <j@w1.fi>
Date: Sun, 9 Mar 2014 22:44:26 +0000 (+0200)
Subject: Fix error path handling on radius_accept_attr
X-Git-Tag: hostap_2_2~622
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4fb363c62b0c1fd5e7ba537cd8e419cad831ba70;p=thirdparty%2Fhostap.git

Fix error path handling on radius_accept_attr

This error path must not try to free the user entry since that entry was
already added to the BSS list and will be freed when BSS is freed.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/hostapd/config_file.c b/hostapd/config_file.c
index 949a9d171..b7d1f2f14 100644
--- a/hostapd/config_file.c
+++ b/hostapd/config_file.c
@@ -257,6 +257,7 @@ static int hostapd_config_read_eap_user(const char *fname,
 			if (attr == NULL) {
 				wpa_printf(MSG_ERROR, "Invalid radius_auth_req_attr: %s",
 					   buf + 19);
+				user = NULL; /* already in the BSS list */
 				goto failed;
 			}
 			if (user->accept_attr == NULL) {