From: Ján Tomko Date: Thu, 28 Mar 2019 14:01:45 +0000 (+0100) Subject: qemu: error out on attempt to change blkiotune group name X-Git-Tag: v5.2.0-rc2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4fbc8ddcd04331601c5c31787a94c632c62bcbd3;p=thirdparty%2Flibvirt.git qemu: error out on attempt to change blkiotune group name Check that the attribute is the same in qemuDomainDiskChangeSupported in case somebody tries to change it using the UpdateDevice API. https://bugzilla.redhat.com/show_bug.cgi?id=1601677 Signed-off-by: Ján Tomko Reviewed-by: Laine Stump --- diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index f856a5b081..c6188b38ce 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9397,6 +9397,8 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk, CHECK_EQ(blkdeviotune.size_iops_sec, "blkdeviotune size_iops_sec", true); + CHECK_STREQ_NULLABLE(blkdeviotune.group_name, + "blkdeviotune group name"); if (disk->serial && STRNEQ_NULLABLE(disk->serial, orig_disk->serial)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED,