From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 11 Sep 2023 00:20:57 +0000 (-0400)
Subject: comment out assertion check
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4fc293da792d371d961c149c75f58dbbd2968d34;p=thirdparty%2Ffreeradius-server.git

comment out assertion check

because it fails for update sections, where the vp being deleted
isn't parented from the list!

If we add the migration flags

	-S rewrite_update=yes -S tmpl_tokenize_all_nested=yes

then the test passes.  We'll leave these checks disabled until
we either find and fix the issue (if we care) or until we enable
everything nested.
---

diff --git a/src/lib/util/pair_inline.c b/src/lib/util/pair_inline.c
index 3f17ddfd821..784faeb2648 100644
--- a/src/lib/util/pair_inline.c
+++ b/src/lib/util/pair_inline.c
@@ -93,8 +93,13 @@ _INLINE fr_pair_t *fr_pair_list_prev(fr_pair_list_t const *list, fr_pair_t const
  */
 _INLINE fr_pair_t *fr_pair_remove(fr_pair_list_t *list, fr_pair_t *vp)
 {
-#ifdef WITH_VERIFY_PTR
+	/*
+	 *	This check is commented out because it fails for
+	 *	update sections, things really don't work right :(
+	 */
+#if 0
 	fr_assert(fr_pair_order_list_in_a_list(vp));
+	fr_assert(list == fr_pair_parent_list(vp));
 	list->verified = false;
 #endif