From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Tue, 7 Apr 2020 07:19:49 +0000 (+0300)
Subject: lib-mail: test-message-address - Add unit test for the one byte overread
X-Git-Tag: 2.3.11.2~471
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=501309a3805ad9c358a284f9be90597b59cc92db;p=thirdparty%2Fdovecot%2Fcore.git

lib-mail: test-message-address - Add unit test for the one byte overread

Note that this is visible only with valgrind.
---

diff --git a/src/lib-mail/test-message-address.c b/src/lib-mail/test-message-address.c
index 3cb1b40d0d..2488114cc7 100644
--- a/src/lib-mail/test-message-address.c
+++ b/src/lib-mail/test-message-address.c
@@ -442,6 +442,8 @@ static void test_message_address_path(void)
 		  { NULL, NULL, NULL, "user\"name", "domain", FALSE } },
 		{ "<\"\"@domain>", NULL,
 		  { NULL, NULL, NULL, "", "domain", FALSE } },
+		{ "<@source", "<>",
+		  { NULL, NULL, NULL, NULL, NULL, TRUE } },
 	};
 	const struct message_address *addr;
 	string_t *str;
@@ -458,7 +460,10 @@ static void test_message_address_path(void)
 
 		test_wanted_addr = &test->addr;
 		ret = test_parse_path(test->input, &addr);
-		test_assert_idx(ret == 0, i);
+		if (addr->invalid_syntax)
+			test_assert_idx(ret == -1, i);
+		else
+			test_assert_idx(ret == 0, i);
 		test_assert_idx(addr != NULL && addr->next == NULL &&
 				cmp_addr(addr, test_wanted_addr), i);