From: Andreas Schneider <asn@samba.org>
Date: Fri, 1 Apr 2016 08:15:39 +0000 (+0200)
Subject: libcli:smb2: Use constant time memcmp() to verify the signature
X-Git-Tag: talloc-2.1.7~223
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5035f1afa9b9f34e68b6743f3f4a66b9377dedab;p=thirdparty%2Fsamba.git

libcli:smb2: Use constant time memcmp() to verify the signature

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/libcli/smb/smb2_signing.c b/libcli/smb/smb2_signing.c
index b72355429ef..90d80cc9ba0 100644
--- a/libcli/smb/smb2_signing.c
+++ b/libcli/smb/smb2_signing.c
@@ -167,7 +167,7 @@ NTSTATUS smb2_signing_check_pdu(DATA_BLOB signing_key,
 		memcpy(res, digest, 16);
 	}
 
-	if (memcmp(res, sig, 16) != 0) {
+	if (memcmp_const_time(res, sig, 16) != 0) {
 		DEBUG(0,("Bad SMB2 signature for message\n"));
 		dump_data(0, sig, 16);
 		dump_data(0, res, 16);