From: mkanat%bugzilla.org <>
Date: Tue, 22 Sep 2009 00:20:56 +0000 (+0000)
Subject: Bug 517632: Make checksetup.pl die when it fails to create a directory
X-Git-Tag: bugzilla-3.5.1~63
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=50642a730f219e57257745c0f92606f16c883aea;p=thirdparty%2Fbugzilla.git

Bug 517632: Make checksetup.pl die when it fails to create a directory
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat
---

diff --git a/Bugzilla/Install/Filesystem.pm b/Bugzilla/Install/Filesystem.pm
index 763fd85bfe..fcc159008b 100644
--- a/Bugzilla/Install/Filesystem.pm
+++ b/Bugzilla/Install/Filesystem.pm
@@ -335,10 +335,10 @@ sub update_filesystem {
     foreach my $dir (sort keys %dirs) {
         unless (-d $dir) {
             print "Creating $dir directory...\n";
-            mkdir $dir || die $!;
+            mkdir $dir or die "mkdir $dir failed: $!";
             # For some reason, passing in the permissions to "mkdir"
             # doesn't work right, but doing a "chmod" does.
-            chmod $dirs{$dir}, $dir || die $!;
+            chmod $dirs{$dir}, $dir or warn "Cannot chmod $dir: $!";
         }
     }