From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 27 Nov 2012 12:57:57 +0000 (+0000)
Subject: Fix leak of virNetworkPtr in LXC startup failure path
X-Git-Tag: CVE-2012-3411~55
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=509ce9437ff77db84b5b035ad6b778fa8548a684;p=thirdparty%2Flibvirt.git

Fix leak of virNetworkPtr in LXC startup failure path

When starting an LXC guest with a virNetwork based NIC device,
if the network was not active, the virNetworkPtr device would
be leaked

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index 28eecec1aa..514ef81f44 100644
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -468,7 +468,6 @@ static int virLXCProcessSetupInterfaces(virConnectPtr conn,
                     virReportError(VIR_ERR_INTERNAL_ERROR,
                                    _("Network '%s' is not active."),
                                    def->nets[i]->data.network.name);
-                goto cleanup;
             }
 
             if (!fail) {