From: Eric Blake <eblake@redhat.com>
Date: Tue, 2 Aug 2011 15:50:54 +0000 (-0600)
Subject: rpc: avoid double close on error
X-Git-Tag: v0.9.4~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=50ae1de27c34957c087888a33230d027d404bf13;p=thirdparty%2Flibvirt.git

rpc: avoid double close on error

Spotted by coverity.  If pipe2 fails, then we attempt to close
uninitialized fds, which may result in a double-close.

* src/rpc/virnetserver.c (virNetServerSignalSetup): Initialize fds.
---

diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index 2dae2ffa93..4deeca17db 100644
--- a/src/rpc/virnetserver.c
+++ b/src/rpc/virnetserver.c
@@ -471,7 +471,7 @@ cleanup:
 
 static int virNetServerSignalSetup(virNetServerPtr srv)
 {
-    int fds[2];
+    int fds[2] = { -1, -1 };
 
     if (srv->sigwrite != -1)
         return 0;