From: John Ferlan <jferlan@redhat.com>
Date: Thu, 28 Feb 2013 14:46:34 +0000 (-0500)
Subject: libxl_conf: Resolve Coverity issue with call to regcomp()
X-Git-Tag: v1.0.4-rc1~156
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=50de0e0807c27a660ace9550018e7d10b3ed6b5a;p=thirdparty%2Flibvirt.git

libxl_conf: Resolve Coverity issue with call to regcomp()
---

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 4ce5deceee..b208dd8fb1 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -769,10 +769,19 @@ error:
 virCapsPtr
 libxlMakeCapabilities(libxl_ctx *ctx)
 {
+    int err;
     libxl_physinfo phy_info;
     const libxl_version_info *ver_info;
 
-    regcomp(&xen_cap_rec, xen_cap_re, REG_EXTENDED);
+    err = regcomp(&xen_cap_rec, xen_cap_re, REG_EXTENDED);
+    if (err != 0) {
+        char error[100];
+        regerror(err, &xen_cap_rec, error, sizeof(error));
+        regfree(&xen_cap_rec);
+        virReportError(VIR_ERR_INTERNAL_ERROR,
+                       _("Failed to compile regex %s"), error);
+        return NULL;
+    }
 
     if (libxl_get_physinfo(ctx, &phy_info) != 0) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",