From: Greg MacLellan <greg@gregmaclellan.com>
Date: Fri, 30 Apr 2021 20:29:51 +0000 (-0400)
Subject: Fix documentation around get*DomainMetadata
X-Git-Tag: dnsdist-1.7.0-alpha1~141^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=513e82340102a0162cd0d602cbb3f231f3a38743;p=thirdparty%2Fpdns.git

Fix documentation around get*DomainMetadata

* `GetDomainMetadata` and `GetAllDomainMetadata` state `false` can be returned, but doing this results in an error.
* Somewhere between PowerDNS 4.2 and 4.4, `GetAllDomainMetadata` became mandatory: a backend returning 404 will result in PowerDNS responding with `SERVFAIL`.
---

diff --git a/docs/backends/remote.rst b/docs/backends/remote.rst
index 3e82e3d85a..3b84224d7c 100644
--- a/docs/backends/remote.rst
+++ b/docs/backends/remote.rst
@@ -330,9 +330,9 @@ Response:
 
 Returns the value(s) for variable kind for zone name. You **must**
 always return something, if there are no values, you shall return empty
-set or false.
+set.
 
-*  Mandatory: No
+*  Mandatory: yes
 *  Parameters: name
 *  Reply: hash of key to array of strings
 
@@ -375,7 +375,7 @@ Response:
 Returns the value(s) for variable kind for zone name. Most commonly it's
 one of NSEC3PARAM, PRESIGNED, SOA-EDIT. Can be others, too. You **must**
 always return something, if there are no values, you shall return empty
-array or false.
+array.
 
 -  Mandatory: No
 -  Parameters: name, kind