From: Volker Lendecke <vl@samba.org>
Date: Mon, 26 Aug 2019 16:56:24 +0000 (+0200)
Subject: smbd: Avoid calling remove_stale_share_mode_entries() in open.c
X-Git-Tag: talloc-2.3.1~784
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5151b6d58be54d210795e7769033cb33e6c75b0a;p=thirdparty%2Fsamba.git

smbd: Avoid calling remove_stale_share_mode_entries() in open.c

All places that matter explicitly check for staleness. This cleanup
action should only happen before writing the database

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 73fdaa09d59..d9146f0582d 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -1897,8 +1897,6 @@ static bool validate_oplock_types(struct share_mode_lock *lck)
 		return false;
 	}
 
-	remove_stale_share_mode_entries(lck->data);
-
 	if ((state.batch || state.ex_or_batch) &&
 	    (state.num_non_stat_opens != 1)) {
 		DBG_WARNING("got batch (%d) or ex (%d) non-exclusively "