From: Phil Sutter Date: Fri, 17 Aug 2018 16:38:46 +0000 (+0200) Subject: lib: Make check_enable_color() return boolean X-Git-Tag: v4.19.0~66 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=515a766cd29bbed8a180733e93bc8590b001cad7;p=thirdparty%2Fiproute2.git lib: Make check_enable_color() return boolean As suggested, turn return code into true/false although it's not checked anywhere yet. Fixes: 4d82962cccc6a ("Merge common code for conditionally colored output") Signed-off-by: Phil Sutter Signed-off-by: Stephen Hemminger --- diff --git a/include/color.h b/include/color.h index a22a00c22..e30f28c51 100644 --- a/include/color.h +++ b/include/color.h @@ -21,7 +21,7 @@ enum color_opt { }; void enable_color(void); -int check_enable_color(int color, int json); +bool check_enable_color(int color, int json); bool matches_color(const char *arg, int *val); void set_color_palette(void); int color_fprintf(FILE *fp, enum color_attr attr, const char *fmt, ...); diff --git a/lib/color.c b/lib/color.c index 9c9023587..eaf69e74d 100644 --- a/lib/color.c +++ b/lib/color.c @@ -79,16 +79,16 @@ void enable_color(void) set_color_palette(); } -int check_enable_color(int color, int json) +bool check_enable_color(int color, int json) { if (json || color == COLOR_OPT_NEVER) - return 1; + return false; if (color == COLOR_OPT_ALWAYS || isatty(fileno(stdout))) { enable_color(); - return 0; + return true; } - return 1; + return false; } bool matches_color(const char *arg, int *val)