From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Tue, 5 Oct 2021 06:47:22 +0000 (+1300)
Subject: tests/krb5: Provide clearer assertion messages for test failures
X-Git-Tag: ldb-2.5.0~422
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5233f002000f196875af488b4f4d1df26fca90de;p=thirdparty%2Fsamba.git

tests/krb5: Provide clearer assertion messages for test failures

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14642

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/krb5/raw_testcase.py b/python/samba/tests/krb5/raw_testcase.py
index b51ad499192..188a54451d3 100644
--- a/python/samba/tests/krb5/raw_testcase.py
+++ b/python/samba/tests/krb5/raw_testcase.py
@@ -1942,7 +1942,12 @@ class RawKerberosTest(TestCaseInTempDir):
             self.assertIsNone(check_error_fn)
             self.assertEqual(0, len(expected_error_mode))
         self.assertIsNotNone(expected_msg_type)
-        self.assertEqual(msg_type, expected_msg_type)
+        if msg_type == KRB_ERROR:
+            error_code = self.getElementValue(rep, 'error-code')
+            fail_msg = f'Got unexpected error: {error_code}'
+        else:
+            fail_msg = f'Expected to fail with error: {expected_error_mode}'
+        self.assertEqual(msg_type, expected_msg_type, fail_msg)
 
         if msg_type == KRB_ERROR:
             return check_error_fn(kdc_exchange_dict,