From: Stefan Metzmacher <metze@samba.org>
Date: Thu, 19 Sep 2024 07:13:03 +0000 (+0200)
Subject: s3:winbindd: make use of dcerpc_binding_handle_get_transport()
X-Git-Tag: samba-4.21.7~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=523484d18828f23ddd52554edf55fd479be5124d;p=thirdparty%2Fsamba.git

s3:winbindd: make use of dcerpc_binding_handle_get_transport()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 504906e60f9a09518202397f0aa0782242dbe3bb)
---

diff --git a/source3/winbindd/winbindd_msrpc.c b/source3/winbindd/winbindd_msrpc.c
index 0c849c04e19..9324633aa14 100644
--- a/source3/winbindd/winbindd_msrpc.c
+++ b/source3/winbindd/winbindd_msrpc.c
@@ -981,7 +981,7 @@ NTSTATUS winbindd_lookup_sids(TALLOC_CTX *mem_ctx,
 
 	b = cli->binding_handle;
 
-	if (cli->transport->transport == NCACN_IP_TCP) {
+	if (dcerpc_binding_handle_get_transport(b) == NCACN_IP_TCP) {
 		use_lookupsids3 = true;
 	}
 
@@ -1063,7 +1063,7 @@ static NTSTATUS winbindd_lookup_names(TALLOC_CTX *mem_ctx,
 
 	b = cli->binding_handle;
 
-	if (cli->transport->transport == NCACN_IP_TCP) {
+	if (dcerpc_binding_handle_get_transport(b) == NCACN_IP_TCP) {
 		use_lookupnames4 = true;
 	}
 
diff --git a/source3/winbindd/winbindd_rpc.c b/source3/winbindd/winbindd_rpc.c
index ef015b2fbf2..a609fdd202d 100644
--- a/source3/winbindd/winbindd_rpc.c
+++ b/source3/winbindd/winbindd_rpc.c
@@ -809,6 +809,7 @@ NTSTATUS rpc_lookup_sids(TALLOC_CTX *mem_ctx,
 {
 	struct lsa_TransNameArray *names = *pnames;
 	struct rpc_pipe_client *cli = NULL;
+	struct dcerpc_binding_handle *b = NULL;
 	struct policy_handle lsa_policy;
 	uint32_t count;
 	uint32_t i;
@@ -819,12 +820,14 @@ NTSTATUS rpc_lookup_sids(TALLOC_CTX *mem_ctx,
 		return status;
 	}
 
-	if (cli->transport->transport == NCACN_IP_TCP) {
+	b = cli->binding_handle;
+
+	if (dcerpc_binding_handle_get_transport(b) == NCACN_IP_TCP) {
 		return rpc_try_lookup_sids3(mem_ctx, domain, cli, sids,
 					    pdomains, pnames);
 	}
 
-	status = dcerpc_lsa_LookupSids(cli->binding_handle, mem_ctx,
+	status = dcerpc_lsa_LookupSids(b, mem_ctx,
 				       &lsa_policy, sids, pdomains,
 				       names, LSA_LOOKUP_NAMES_ALL,
 				       &count, &result);