From: Volker Lendecke <vl@samba.org>
Date: Tue, 24 Mar 2009 22:29:35 +0000 (-0700)
Subject: Fix two memleaks in the encryption code
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=525af716cd52500a4e3dccf9eeb9ea85f86be7ca;p=thirdparty%2Fsamba.git

Fix two memleaks in the encryption code

ntlmssp_seal_packet creates its own signature data blob, which we then
have to free.

Jeremy, please check and merge appropriately (Yes, I'm asking you to do the
janitor work, I want you to *look* at this :-))

Volker
---

diff --git a/source/libsmb/smb_seal.c b/source/libsmb/smb_seal.c
index 795c8bc14ca..2f7305c5b65 100644
--- a/source/libsmb/smb_seal.c
+++ b/source/libsmb/smb_seal.c
@@ -136,7 +136,7 @@ NTSTATUS common_ntlm_encrypt_buffer(NTLMSSP_STATE *ntlmssp_state,
 
 	smb_set_enclen(buf_out, smb_len(buf) + NTLMSSP_SIG_SIZE, enc_ctx_num);
 
-	sig = data_blob(NULL, NTLMSSP_SIG_SIZE);
+	ZERO_STRUCT(sig);
 
 	status = ntlmssp_seal_packet(ntlmssp_state,
 		(unsigned char *)buf_out + 8 + NTLMSSP_SIG_SIZE, /* 4 byte len + 0xFF 'S' <enc> <ctx> */
@@ -153,6 +153,7 @@ NTSTATUS common_ntlm_encrypt_buffer(NTLMSSP_STATE *ntlmssp_state,
 
 	/* First 16 data bytes are signature for SSPI compatibility. */
 	memcpy(buf_out + 8, sig.data, NTLMSSP_SIG_SIZE);
+	data_blob_free(&sig);
 	*ppbuf_out = buf_out;
 	return NT_STATUS_OK;
 }