From: Russell Bryant <russell@russellbryant.com>
Date: Wed, 18 Jul 2007 22:52:54 +0000 (+0000)
Subject: I thought I noticed a memory leak earlier when I saw that the contents of this
X-Git-Tag: 1.6.0-beta1~3^2~2018
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5272289355575e74f73e9054e7994fc4c1f2af48;p=thirdparty%2Fasterisk.git

I thought I noticed a memory leak earlier when I saw that the contents of this
list were not destroyed when the module is unloaded.  However, after reading
the code related to the use of this list a lot today, I realized that it isn't
necessary.  So, I have added a comment to explain why it isn't necessary.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75806 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_iax2.c b/channels/chan_iax2.c
index 6fd9b16ca0..f9cd417dde 100644
--- a/channels/chan_iax2.c
+++ b/channels/chan_iax2.c
@@ -646,6 +646,13 @@ struct chan_iax2_pvt {
 	int frames_received;
 };
 
+/*!
+ * \brief a list of frames that may need to be retransmitted
+ *
+ * \note The contents of this list do not need to be explicitly destroyed
+ * on module unload.  This is because all active calls are destroyed, and
+ * all frames in this queue will get destroyed as a part of that process.
+ */
 static AST_LIST_HEAD_STATIC(frame_queue, iax_frame);
 
 static AST_LIST_HEAD_STATIC(users, iax2_user);
@@ -10807,9 +10814,10 @@ static int __unload_module(void)
 	
 	ast_netsock_release(netsock);
 	ast_netsock_release(outsock);
-	for (x=0;x<IAX_MAX_CALLS;x++)
+	for (x = 0; x < IAX_MAX_CALLS; x++) {
 		if (iaxs[x])
 			iax2_destroy(x);
+	}
 	ast_manager_unregister( "IAXpeers" );
 	ast_manager_unregister( "IAXnetstats" );
 	ast_unregister_application(papp);