From: Philippe Antoine <pantoine@oisf.net>
Date: Wed, 19 Feb 2025 20:09:16 +0000 (+0100)
Subject: plugin: constify some fields
X-Git-Tag: suricata-8.0.0-beta1~201
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52862e50bed3e155d01b28c73f17ad8896bf28ab;p=thirdparty%2Fsuricata.git

plugin: constify some fields

including the tx parameter to the logger function
---

diff --git a/rust/sys/src/sys.rs b/rust/sys/src/sys.rs
index cf6f060a3e..99341dbbec 100644
--- a/rust/sys/src/sys.rs
+++ b/rust/sys/src/sys.rs
@@ -109,14 +109,14 @@ extern "C" {
 #[derive(Debug, Copy, Clone)]
 pub struct SCAppLayerPlugin_ {
     pub version: u64,
-    pub name: *mut ::std::os::raw::c_char,
+    pub name: *const ::std::os::raw::c_char,
     pub Register: ::std::option::Option<unsafe extern "C" fn()>,
     pub KeywordsRegister: ::std::option::Option<unsafe extern "C" fn()>,
-    pub logname: *mut ::std::os::raw::c_char,
-    pub confname: *mut ::std::os::raw::c_char,
+    pub logname: *const ::std::os::raw::c_char,
+    pub confname: *const ::std::os::raw::c_char,
     pub Logger: ::std::option::Option<
         unsafe extern "C" fn(
-            tx: *mut ::std::os::raw::c_void,
+            tx: *const ::std::os::raw::c_void,
             jb: *mut ::std::os::raw::c_void,
         ) -> bool,
     >,
diff --git a/src/suricata-plugin.h b/src/suricata-plugin.h
index 8bc2183d70..4db7cc4d3a 100644
--- a/src/suricata-plugin.h
+++ b/src/suricata-plugin.h
@@ -58,12 +58,12 @@ int SCPluginRegisterCapture(SCCapturePlugin *);
 typedef struct SCAppLayerPlugin_ {
     // versioning to check suricata/plugin API compatibility
     uint64_t version;
-    char *name;
+    const char *name;
     void (*Register)(void);
     void (*KeywordsRegister)(void);
-    char *logname;
-    char *confname;
-    bool (*Logger)(void *tx, void *jb);
+    const char *logname;
+    const char *confname;
+    bool (*Logger)(const void *tx, void *jb);
 } SCAppLayerPlugin;
 
 int SCPluginRegisterAppLayer(SCAppLayerPlugin *);