From: Matthias Bolte <matthias.bolte@googlemail.com>
Date: Sat, 3 Apr 2010 22:51:57 +0000 (+0200)
Subject: nwfilter: Fix random index in virNWFilterRuleDefDetailsFormat
X-Git-Tag: v0.8.0~101
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5288b2ad8e2c0f40436eec8cfd5ef27dec1b1f6c;p=thirdparty%2Flibvirt.git

nwfilter: Fix random index in virNWFilterRuleDefDetailsFormat

An uninitialized int value was used to index an array. This can
result in a segfault in nwfilterxml2xmltest.
---

diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
index 08934fb0af..7c71ece18b 100644
--- a/src/conf/nwfilter_conf.c
+++ b/src/conf/nwfilter_conf.c
@@ -2375,7 +2375,7 @@ virNWFilterRuleDefDetailsFormat(virConnectPtr conn,
                                 const virXMLAttr2Struct *att,
                                 virNWFilterRuleDefPtr def)
 {
-    int i, j;
+    int i = 0, j;
     bool typeShown = 0;
     bool neverShown = 1;
     enum match {