From: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Date: Mon, 14 Sep 2020 19:59:25 +0000 (+0200)
Subject: auth: remove UeberBackend::getSOA
X-Git-Tag: auth-4.4.0-alpha2~12^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52977ff7152d4084f66e86d17eccbfb8f240b1d6;p=thirdparty%2Fpdns.git

auth: remove UeberBackend::getSOA
---

diff --git a/pdns/ueberbackend.cc b/pdns/ueberbackend.cc
index 38717e0f34..99337919bd 100644
--- a/pdns/ueberbackend.cc
+++ b/pdns/ueberbackend.cc
@@ -402,28 +402,6 @@ found:
   return found;
 }
 
-bool UeberBackend::getSOA(const DNSName &domain, SOAData &sd)
-{
-  d_question.qtype=QType::SOA;
-  d_question.qname=domain;
-  d_question.zoneId=-1;
-    
-  int cstat=cacheHas(d_question,d_answers);
-  if(cstat==0) { // negative
-    return false;
-  }
-  else if(cstat==1 && !d_answers.empty()) {
-    fillSOAData(d_answers[0],sd);
-    sd.domain_id=d_answers[0].domain_id;
-    sd.ttl=d_answers[0].dr.d_ttl;
-    sd.db = nullptr;
-    return true;
-  }
-
-  // not found in neg. or pos. cache, look it up
-  return getSOAUncached(domain, sd);
-}
-
 bool UeberBackend::getSOAUncached(const DNSName &domain, SOAData &sd)
 {
   d_question.qtype=QType::SOA;
diff --git a/pdns/ueberbackend.hh b/pdns/ueberbackend.hh
index 4a21569ca0..8c0abda14c 100644
--- a/pdns/ueberbackend.hh
+++ b/pdns/ueberbackend.hh
@@ -97,7 +97,7 @@ public:
 
   /** Determines if we are authoritative for a zone, and at what level */
   bool getAuth(const DNSName &target, const QType &qtype, SOAData* sd, bool cachedOk=true);
-  bool getSOA(const DNSName &domain, SOAData &sd);
+
   /** Load SOA info from backends, ignoring the cache.*/
   bool getSOAUncached(const DNSName &domain, SOAData &sd);
   bool get(DNSZoneRecord &r);