From: Razvan Becheriu <razvan@isc.org>
Date: Sat, 20 Apr 2019 09:37:09 +0000 (+0300)
Subject: fixed warnings
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=529ffb9a17b70a4c8bce17bbfee06ab5454cd944;p=thirdparty%2Fkea.git

fixed warnings
---

diff --git a/src/bin/dhcp4/dhcp4_srv.cc b/src/bin/dhcp4/dhcp4_srv.cc
index 4b2783c128..1f907bbba9 100644
--- a/src/bin/dhcp4/dhcp4_srv.cc
+++ b/src/bin/dhcp4/dhcp4_srv.cc
@@ -447,9 +447,9 @@ const std::string Dhcpv4Srv::VENDOR_CLASS_PREFIX("VENDOR_CLASS_");
 Dhcpv4Srv::Dhcpv4Srv(uint16_t server_port, uint16_t client_port,
                      bool run_multithreaded /* = false */,
                      const bool use_bcast, const bool direct_response_desired)
-    : io_service_(new IOService()), shutdown_(true), alloc_engine_(),
-      server_port_(server_port), use_bcast_(use_bcast),
-      client_port_(client_port),
+    : io_service_(new IOService()), server_port_(server_port),
+      client_port_(client_port), use_bcast_(use_bcast),
+      shutdown_(true), alloc_engine_(),
       network_state_(new NetworkState(NetworkState::DHCPv4)),
       cb_control_(new CBControlDHCPv4()),
       run_multithreaded_(run_multithreaded) {
diff --git a/src/bin/dhcp4/dhcp4_srv.h b/src/bin/dhcp4/dhcp4_srv.h
index 7364f74df2..7744d69dda 100644
--- a/src/bin/dhcp4/dhcp4_srv.h
+++ b/src/bin/dhcp4/dhcp4_srv.h
@@ -901,10 +901,6 @@ protected:
                                           bool& drop,
                                           bool sanity_only = false) const;
 
-    /// indicates if shutdown is in progress. Setting it to true will
-    /// initiate server shutdown procedure.
-    volatile bool shutdown_;
-
     /// @brief dummy wrapper around IfaceMgr::receive4
     ///
     /// This method is useful for testing purposes, where its replacement
@@ -1003,14 +999,18 @@ private:
     /// UDP port number on which server listens.
     uint16_t server_port_;
 
-    /// Should broadcast be enabled on sockets (if true).
-    bool use_bcast_;
-
 protected:
 
     /// UDP port number to which server sends responses.
     uint16_t client_port_;
 
+    /// Should broadcast be enabled on sockets (if true).
+    bool use_bcast_;
+
+    /// indicates if shutdown is in progress. Setting it to true will
+    /// initiate server shutdown procedure.
+    volatile bool shutdown_;
+
     /// @brief Allocation Engine.
     /// Pointer to the allocation engine that we are currently using
     /// It must be a pointer, because we will support changing engines
diff --git a/src/bin/dhcp6/dhcp6_srv.cc b/src/bin/dhcp6/dhcp6_srv.cc
index 16faac53ea..4c48d70be0 100644
--- a/src/bin/dhcp6/dhcp6_srv.cc
+++ b/src/bin/dhcp6/dhcp6_srv.cc
@@ -184,8 +184,9 @@ const std::string Dhcpv6Srv::VENDOR_CLASS_PREFIX("VENDOR_CLASS_");
 Dhcpv6Srv::Dhcpv6Srv(uint16_t server_port, uint16_t client_port,
                      bool run_multithreaded /* = false */)
     : io_service_(new IOService()), server_port_(server_port),
-      client_port_(client_port), serverid_(), shutdown_(true),
-      alloc_engine_(), name_change_reqs_(),
+      client_port_(client_port), serverid_(),
+      shutdown_(true), alloc_engine_(),
+      name_change_reqs_(),
       network_state_(new NetworkState(NetworkState::DHCPv6)),
       cb_control_(new CBControlDHCPv6()),
       run_multithreaded_(run_multithreaded) {