From: Roy Marples <roy@marples.name>
Date: Tue, 20 Aug 2019 22:12:56 +0000 (+0100)
Subject: Add a note about prior likely being a libc bug.
X-Git-Tag: v8.0.3~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52a5a99599dcb3b1a5322c65c2ee7992c0d10609;p=thirdparty%2Fdhcpcd.git

Add a note about prior likely being a libc bug.
---

diff --git a/src/if.c b/src/if.c
index d9f5d19f..efc92efa 100644
--- a/src/if.c
+++ b/src/if.c
@@ -513,6 +513,9 @@ if_discover(struct dhcpcd_ctx *ctx, struct ifaddrs **ifaddrs,
 		}
 #ifdef SIOCGIFHWADDR
 		else {
+			/* This is a huge bug in getifaddrs(3) as there
+			 * is no reason why this can't be returned in
+			 * ifa_addr. */
 			memset(&ifr, 0, sizeof(ifr));
 			strlcpy(ifr.ifr_name, ifa->ifa_name,
 			    sizeof(ifr.ifr_name));