From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sun, 29 Dec 2024 19:59:25 +0000 (+0000)
Subject: file: Check if we actually returned a file handle
X-Git-Tag: 0.9.30~653
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52ad39a36c04b0883bdf4d993207ac69af1dc50e;p=pakfire.git

file: Check if we actually returned a file handle

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/file.c b/src/libpakfire/file.c
index 390529f76..a86a91ced 100644
--- a/src/libpakfire/file.c
+++ b/src/libpakfire/file.c
@@ -1108,6 +1108,7 @@ int pakfire_file_open(struct pakfire_file* file) {
 }
 
 FILE* pakfire_file_fopen(struct pakfire_file* file) {
+	FILE* f = NULL;
 	int fd = -EBADF;
 
 	// Open the file descriptor
@@ -1116,7 +1117,14 @@ FILE* pakfire_file_fopen(struct pakfire_file* file) {
 		return NULL;
 
 	// Return a file handle
-	return fdopen(fd, "r+");
+	f = fdopen(fd, "r");
+	if (!f) {
+		ERROR(file->ctx, "Could not open file handle for %s: %m\n",
+			pakfire_file_get_path(file));
+		return NULL;
+	}
+
+	return f;
 }
 
 int pakfire_file_payload_matches(struct pakfire_file* file,