From: Chris Lalancette <clalance@redhat.com>
Date: Fri, 23 Apr 2010 15:59:39 +0000 (-0400)
Subject: Fix memory leak in virsh snapshot-list.
X-Git-Tag: v0.8.1~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52ae076a941b04f4196fe37c4972a783c2120112;p=thirdparty%2Flibvirt.git

Fix memory leak in virsh snapshot-list.

We were forgetting to release the memory allocated by
virDomainSnapshotListNames.  Free the memory properly.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
---

diff --git a/tools/virsh.c b/tools/virsh.c
index b2a1538b80..5bcf0ede9a 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -8360,7 +8360,7 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
     int ret = FALSE;
     int numsnaps;
     char **names = NULL;
-    int actual;
+    int actual = 0;
     int i;
     xmlDocPtr xml = NULL;
     xmlXPathContextPtr ctxt = NULL;
@@ -8447,6 +8447,8 @@ cleanup:
     if (xml)
         xmlFreeDoc(xml);
     VIR_FREE(doc);
+    for (i = 0; i < actual; i++)
+        VIR_FREE(names[i]);
     VIR_FREE(names);
     if (dom)
         virDomainFree(dom);