From: Laine Stump <laine@laine.org>
Date: Fri, 3 May 2013 18:30:55 +0000 (-0400)
Subject: qemu: fix stupid typos in VFIO cgroup setup/teardown
X-Git-Tag: CVE-2013-1962~198
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52ba0f6e1cf29e791be4e079408c0de851100b65;p=thirdparty%2Flibvirt.git

qemu: fix stupid typos in VFIO cgroup setup/teardown

I must have looked at this a couple dozen times before I noticed it
had "!=" instead of "==". Not doing this setup prevented qemu from
doing anything with the vfio group device.
---

diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 4819cfe99b..9c45b76a25 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -237,7 +237,7 @@ qemuSetupHostdevCGroup(virDomainObjPtr vm,
         switch (dev->source.subsys.type) {
         case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
             if (dev->source.subsys.u.pci.backend
-                != VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
+                == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
                 int rc;
 
                 pci = virPCIDeviceNew(dev->source.subsys.u.pci.addr.domain,
@@ -323,7 +323,7 @@ qemuTeardownHostdevCgroup(virDomainObjPtr vm,
         switch (dev->source.subsys.type) {
         case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
             if (dev->source.subsys.u.pci.backend
-                != VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
+                == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
                 int rc;
 
                 pci = virPCIDeviceNew(dev->source.subsys.u.pci.addr.domain,