From: Andreas Schneider <asn@samba.org>
Date: Thu, 21 Mar 2019 15:06:05 +0000 (+0100)
Subject: s3:script: Fix running cp in modprinter.pl
X-Git-Tag: tdb-1.4.1~658
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52bf5c25261e343d3c1d4ea1a414ab74cf75d76c;p=thirdparty%2Fsamba.git

s3:script: Fix running cp in modprinter.pl

We need to unset BASH_ENV or we get:
    Insecure $ENV{BASH_ENV} while running setgid

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Mar 21 16:41:33 UTC 2019 on sn-devel-144
---

diff --git a/source3/script/tests/printing/modprinter.pl b/source3/script/tests/printing/modprinter.pl
index ec1ebcd7ab8..fc71e665451 100755
--- a/source3/script/tests/printing/modprinter.pl
+++ b/source3/script/tests/printing/modprinter.pl
@@ -131,6 +131,8 @@ if ($opt_delete && ($found_section == 0)) {
 	die "share $share_name not found";
 }
 
+delete @ENV{'BASH_ENV'};
+
 $ENV{'PATH'} = '/bin:/usr/bin'; # untaint PATH
 system("cp", "$tmp", "$smb_conf_file");
 unlink $tmp;