From: Thodoris Sotiropoulos Date: Thu, 11 Jun 2020 14:50:41 +0000 (-0400) Subject: Add 'exists' to SQLite's reserved keywords X-Git-Tag: rel_1_3_18~7 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52c50fee2d082901f8d830f1963fc18bd01185ce;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git Add 'exists' to SQLite's reserved keywords Added "exists" to the list of reserved words for SQLite so that this word will be quoted when used as a label or column name. Pull request courtesy Thodoris Sotiropoulos. Fixes: #5395 Closes: #5396 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5396 Pull-request-sha: 5608317a38db7b63115e3b467d182a3e5cc31580 Change-Id: Ia4769de2dec159dcf282eb4b30c11560da51a5c7 (cherry picked from commit ed4a4896aea7dd77dd5d8a9861302811ac421e47) --- diff --git a/doc/build/changelog/unreleased_13/5395.rst b/doc/build/changelog/unreleased_13/5395.rst new file mode 100644 index 0000000000..9e11cdcbaf --- /dev/null +++ b/doc/build/changelog/unreleased_13/5395.rst @@ -0,0 +1,7 @@ +.. change:: + :tags: bug, sqlite + :tickets: 5395 + + Added "exists" to the list of reserved words for SQLite so that this word + will be quoted when used as a label or column name. Pull request courtesy + Thodoris Sotiropoulos. diff --git a/lib/sqlalchemy/dialects/sqlite/base.py b/lib/sqlalchemy/dialects/sqlite/base.py index d19474bff3..5fd856eee3 100644 --- a/lib/sqlalchemy/dialects/sqlite/base.py +++ b/lib/sqlalchemy/dialects/sqlite/base.py @@ -1335,6 +1335,7 @@ class SQLiteIdentifierPreparer(compiler.IdentifierPreparer): "escape", "except", "exclusive", + "exists", "explain", "false", "fail", diff --git a/test/dialect/test_sqlite.py b/test/dialect/test_sqlite.py index a03ad1fdaa..c6ac94aeb6 100644 --- a/test/dialect/test_sqlite.py +++ b/test/dialect/test_sqlite.py @@ -614,6 +614,7 @@ class DialectTest( Column("true", Integer), Column("false", Integer), Column("column", Integer), + Column("exists", Integer), ) try: meta.create_all()