From: Niels Möller <nisse@lysator.liu.se>
Date: Fri, 24 Sep 2021 05:48:11 +0000 (+0200)
Subject: Delete a few old FIXME comments
X-Git-Tag: nettle_3.8_release_20220602~91
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52c86f94ccf5bf3108bf393d05b4bd44eb73e982;p=thirdparty%2Fnettle.git

Delete a few old FIXME comments
---

diff --git a/Makefile.in b/Makefile.in
index c2ce4cd6..e6fc25b8 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -26,7 +26,6 @@ include config.make
 PRE_CPPFLAGS = -I.
 EXTRA_CFLAGS = $(CCPIC)
 
-# FIXME: Add configuration of LIBEXT?
 LIBTARGETS = @IF_STATIC@ libnettle.a @IF_HOGWEED@ libhogweed.a
 SHLIBTARGETS = @IF_SHARED@ $(LIBNETTLE_FORLINK) @IF_HOGWEED@ $(LIBHOGWEED_FORLINK)
 
@@ -67,11 +66,6 @@ check-fat:
 	    NETTLE_FAT_OVERRIDE=$$f $(MAKE) check ; \
 	  done
 
-# FIXME: Remove. These targets aren't supported, but they are expected by the
-# automake generated Makefiles in the lsh build.
-dvi installcheck uninstallcheck:
-	true
-
 all-here: $(TARGETS) $(DOCTARGETS)
 
 nettle_SOURCES = aes-decrypt-internal.c aes-decrypt.c aes-decrypt-table.c \
diff --git a/ecc-curve25519.c b/ecc-curve25519.c
index 5d221ae3..7182b2ff 100644
--- a/ecc-curve25519.c
+++ b/ecc-curve25519.c
@@ -37,7 +37,6 @@
 
 #include <assert.h>
 
-#include "ecc.h"
 #include "ecc-internal.h"
 
 #define USE_REDC 0
diff --git a/ecc-curve448.c b/ecc-curve448.c
index 04b64905..bd87c5b8 100644
--- a/ecc-curve448.c
+++ b/ecc-curve448.c
@@ -38,7 +38,6 @@
 
 #include <assert.h>
 
-#include "ecc.h"
 #include "ecc-internal.h"
 
 #define USE_REDC 0
@@ -252,8 +251,8 @@ const struct ecc_curve _nettle_curve448 =
     NULL,
     ecc_qp1h,
 
-    ecc_mod,	      /* FIXME: Implement optimized mod function */
-    ecc_mod,	      /* FIXME: Implement optimized reduce function */
+    ecc_mod,
+    ecc_mod,
     ecc_mod_inv,
     NULL,
   },
diff --git a/ecc-internal.h b/ecc-internal.h
index c2007846..245a6517 100644
--- a/ecc-internal.h
+++ b/ecc-internal.h
@@ -189,9 +189,8 @@ struct ecc_curve
 {
   /* The prime p. */
   struct ecc_modulo p;
-  /* Group order. FIXME: Currently, many functions rely on q.size ==
-     p.size. This has to change for radix-51 implementation of
-     curve25519 mod p arithmetic. */
+  /* Group order. Currently, many functions rely on q.size ==
+     p.size. */
   struct ecc_modulo q;
 
   unsigned short use_redc;
diff --git a/ecc-secp192r1.c b/ecc-secp192r1.c
index 285278a5..abdad0c9 100644
--- a/ecc-secp192r1.c
+++ b/ecc-secp192r1.c
@@ -39,9 +39,6 @@
 
 #include <assert.h>
 
-/* FIXME: Remove ecc.h include, once prototypes of more internal
-   functions are moved to ecc-internal.h */
-#include "ecc.h"
 #include "ecc-internal.h"
 
 #define USE_REDC 0
diff --git a/ecc-secp224r1.c b/ecc-secp224r1.c
index 98260412..91c337d4 100644
--- a/ecc-secp224r1.c
+++ b/ecc-secp224r1.c
@@ -37,7 +37,6 @@
 # include "config.h"
 #endif
 
-#include "ecc.h"
 #include "ecc-internal.h"
 
 #if HAVE_NATIVE_ecc_secp224r1_modp
diff --git a/ecc-secp256r1.c b/ecc-secp256r1.c
index 9bdd0077..57ecdd5f 100644
--- a/ecc-secp256r1.c
+++ b/ecc-secp256r1.c
@@ -39,7 +39,6 @@
 
 #include <assert.h>
 
-#include "ecc.h"
 #include "ecc-internal.h"
 
 #if HAVE_NATIVE_ecc_secp256r1_redc
diff --git a/ecc-secp384r1.c b/ecc-secp384r1.c
index fef47036..2c00523b 100644
--- a/ecc-secp384r1.c
+++ b/ecc-secp384r1.c
@@ -39,7 +39,6 @@
 
 #include <assert.h>
 
-#include "ecc.h"
 #include "ecc-internal.h"
 
 #define USE_REDC 0
diff --git a/ecc-secp521r1.c b/ecc-secp521r1.c
index 42b7e156..7eda3732 100644
--- a/ecc-secp521r1.c
+++ b/ecc-secp521r1.c
@@ -37,7 +37,6 @@
 # include "config.h"
 #endif
 
-#include "ecc.h"
 #include "ecc-internal.h"
 
 #define USE_REDC 0
diff --git a/ecdsa.h b/ecdsa.h
index 693aca8b..259efc10 100644
--- a/ecdsa.h
+++ b/ecdsa.h
@@ -53,7 +53,7 @@ extern "C" {
 /* High level ECDSA functions.
  *
  * A public key is represented as a struct ecc_point, and a private
- * key as a struct ecc_scalar. FIXME: Introduce some aliases? */
+ * key as a struct ecc_scalar. */
 void
 ecdsa_sign (const struct ecc_scalar *key,
 	    void *random_ctx, nettle_random_func *random,
diff --git a/gostdsa.h b/gostdsa.h
index d479201e..bcad1f95 100644
--- a/gostdsa.h
+++ b/gostdsa.h
@@ -56,7 +56,7 @@ extern "C" {
 /* High level GOST DSA functions.
  *
  * A public key is represented as a struct ecc_point, and a private
- * key as a struct ecc_scalar. FIXME: Introduce some aliases? */
+ * key as a struct ecc_scalar. */
 void
 gostdsa_sign (const struct ecc_scalar *key,
 	      void *random_ctx, nettle_random_func *random,
diff --git a/rsa-sign-tr.c b/rsa-sign-tr.c
index 9e137c7a..f4c30e60 100644
--- a/rsa-sign-tr.c
+++ b/rsa-sign-tr.c
@@ -244,7 +244,6 @@ sec_equal(const mp_limb_t *a, const mp_limb_t *b, size_t limbs)
       z |= (a[i] ^ b[i]);
     }
 
-  /* FIXME: Might compile to a branch instruction on some platforms. */
   return z == 0;
 }
 
diff --git a/testsuite/testutils.c b/testsuite/testutils.c
index 64dbcd0d..626c13fc 100644
--- a/testsuite/testutils.c
+++ b/testsuite/testutils.c
@@ -1382,7 +1382,6 @@ test_rsa_key(struct rsa_public_key *pub,
   
   if (verbose)
     {
-      /* FIXME: Use gmp_printf */
       fprintf(stderr, "Public key: n=");
       mpz_out_str(stderr, 16, pub->n);
       fprintf(stderr, "\n    e=");