From: GuoHan Zhao Date: Wed, 8 Apr 2026 03:17:25 +0000 (+0800) Subject: ui/spice-app: detect runtime directory creation failures X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52cf667ed2285aa2d08db6abed46cdba5c14f9aa;p=thirdparty%2Fqemu.git ui/spice-app: detect runtime directory creation failures spice_app_display_early_init() creates the per-VM runtime directory with g_mkdir_with_parents() before setting up the Spice socket. The code checks for "< -1", but g_mkdir_with_parents() returns -1 on failure, so the error path is never taken. This lets spice-app continue after a directory creation failure and defers the problem to later setup steps. Check for "< 0" instead so the failure is reported immediately and spice-app exits before using an invalid runtime directory. Fixes: d8aec9d9f129 ("display: add -display spice-app launching a Spice client") Signed-off-by: GuoHan Zhao Reviewed-by: Marc-André Lureau Message-ID: <20260408031725.641417-1-zhaoguohan@kylinos.cn> --- diff --git a/ui/spice-app.c b/ui/spice-app.c index 9e55f273715..0df7325e679 100644 --- a/ui/spice-app.c +++ b/ui/spice-app.c @@ -151,7 +151,7 @@ static void spice_app_display_early_init(DisplayOptions *opts) if (qemu_name) { app_dir = g_build_filename(g_get_user_runtime_dir(), "qemu", qemu_name, NULL); - if (g_mkdir_with_parents(app_dir, S_IRWXU) < -1) { + if (g_mkdir_with_parents(app_dir, S_IRWXU) < 0) { error_report("Failed to create directory %s: %s", app_dir, strerror(errno)); exit(1);