From: Noel Power <noel.power@suse.com>
Date: Thu, 8 Aug 2019 14:06:28 +0000 (+0100)
Subject: s3/libads: clang: Fix Value stored to 'canon_princ' is never read
X-Git-Tag: tevent-0.10.1~124
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52d20087f620704549f5a5cdcbec79cb08a36290;p=thirdparty%2Fsamba.git

s3/libads: clang: Fix Value stored to 'canon_princ' is never read

Fixes:

source3/libads/kerberos.c:192:2: warning: Value stored to 'canon_princ' is never read <--[clang]
        canon_princ = me;
        ^             ~~
1 warning generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
index 721c3c2a929..9fbe7dd0f07 100644
--- a/source3/libads/kerberos.c
+++ b/source3/libads/kerberos.c
@@ -189,9 +189,10 @@ int kerberos_kinit_password_ext(const char *principal,
 		goto out;
 	}
 
-	canon_princ = me;
 #ifndef SAMBA4_USES_HEIMDAL /* MIT */
 	canon_princ = my_creds.client;
+#else
+	canon_princ = me;
 #endif /* MIT */
 
 	if ((code = krb5_cc_initialize(ctx, cc, canon_princ))) {