From: Alan T. DeKok Date: Thu, 6 Sep 2012 08:42:18 +0000 (+0200) Subject: Remove double free. Found by Coverity X-Git-Tag: release_3_0_0_beta0~23 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=52deec32999389f0f868dd86bee2b2e5103b9156;p=thirdparty%2Ffreeradius-server.git Remove double free. Found by Coverity --- diff --git a/src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.c b/src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.c index 030b2224c85..02707f3659d 100644 --- a/src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.c +++ b/src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.c @@ -272,9 +272,8 @@ fail: EC_POINT_free(sess->pwe); BN_free(sess->order); BN_free(sess->prime); - if (prfbuf != NULL) { - free(prfbuf); - } + free(prfbuf); + ptrbuf = NULL; free(sess); sess = NULL; ret = -1; @@ -283,9 +282,7 @@ fail: BN_free(cofactor); BN_free(x_candidate); BN_free(rnd); - if (prfbuf != NULL) { - free(prfbuf); - } + free(prfbuf); return ret; }